Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/117#discussion_r10861767
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -21,9 +21,14 @@ import org.apache.spark.SparkContext
import org.apache.spark.rdd.RDD
import org.apache.spark.SparkContext._
+import org.apache.commons.math3.util.Precision.EPSILON
--- End diff --
Pardon my ignorance but is this introducing a dependency on Commons Math
just for this constant? glancing at the code, it's not used now and not
otherwise used in this PR. I know in other parts of the code it made efforts to
not depend on Commons Math.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
