GitHub user CodingCat opened a pull request:

    https://github.com/apache/spark/pull/211

    SPARK-1299: making comments of RDD.doCheckpoint consistent with its usage

    another trivial thing I found occasionally, the comments of consistent is 
saying that
    
    /**
    Performs the checkpointing of this RDD by saving this. It is called by the 
DAGScheduler
    after a job using this RDD has completed (therefore the RDD has been 
materialized and
    potentially stored in memory). doCheckpoint() is called recursively on the 
parent RDDs.
    */
    
    actually this function is called in SparkContext.runJob
    
    we can either change the comments or call it in DAGScheduler, I personally 
prefer the later one, as this calling seems like an auto-checkpoint , better 
put it in a non-user-facing component

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingCat/spark SPARK-1299

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #211
    
----
commit 79559076ea6facdc903c5a6d45bef4ae78adaf95
Author: CodingCat <[email protected]>
Date:   2014-03-23T19:30:30Z

    making comments of RDD.doCheckpoint consistent with its usage

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to