Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/213#discussion_r10877430
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -170,6 +166,23 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
         }
       }
     
    +  object ParquetScans extends Strategy {
    +    def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
    +      // TODO: need to support writing to other types of files.
    +      case logical.WriteToFile(path, child) =>
    --- End diff --
    
    Seems a little confusing to have a write operation within a scan strategy 
here... Maybe we should move this into a separate strategy object similar to 
`HiveStrategies.DataSinks`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to