Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/223#issuecomment-38642325
I took a very high level pass at this and here are some high-level things
that must be fixed.
1. Follow to Spark formatting style, refer to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide . You
can use the Spark in-built style checker using 'sbt/sbt scalastyle'
2. Real unit tests, see in-code comments
3. More documentation, both Java docs and as well in-code documentation.
4. Please add a [JIRA
ticket](https://spark-project.atlassian.net/secure/Dashboard.jspa) for this and
update the PR subject accordingly (see other PRs).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
