Github user LIDIAgroup commented on a diff in the pull request:

    https://github.com/apache/spark/pull/216#discussion_r10969423
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/InfoTheory.scala 
---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.mllib.util
    +
    +import org.apache.spark.mllib.discretization.Utils
    +
    +/**
    + * Object with some Information Theory methods.
    + */
    +object InfoTheory {
    --- End diff --
    
    I placed it in `utils` because the intention is to implement functions of 
Information Theory that can be used in any algorithm. For instance, the 
implemented `entropy` functions work out the entropy for a variable whose 
values have the frequencies stored in `freqs`. This is a general function that 
is used in the discretizer, but can be potentially used in more cases.
    
    If you don't agree with this, there'll be no problem to move it to 
`discretizer` package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to