Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/228#discussion_r10996813
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -831,7 +842,8 @@ class DAGScheduler(
activeJobs -= job
resultStageToJob -= stage
markStageAsFinished(stage)
- jobIdToStageIdsRemove(job.jobId)
+ val stagesToRemove = jobIdToStageIdsRemove(job.jobId)
+ cleanup(stagesToRemove.asInstanceOf[Set[Any]])
--- End diff --
What `cleanup` is doing should either be moved within the `removeStage`
method within `removeJobAndIndependentStages`, or that `removeStage` should be
go into the outer scope and be combined with `cleanup`. Personally, I don't
much care for a generically named function like `cleanup` at the outer scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
