Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/228#discussion_r11094324
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -116,6 +116,9 @@ class DAGScheduler(
private val metadataCleaner =
new MetadataCleaner(MetadataCleanerType.DAG_SCHEDULER, this.cleanup,
env.conf)
+ // stageId -> (splitId -> (acumulatorId, accumulatorValue))
+ val stageIdToAccumulators = new HashMap[Int, HashMap[Int,
ListBuffer[(Long, Any)]]]
--- End diff --
Since this is mutable datastructure - can me make it private ?
For testcase, expose some method which checks for the condition instead of
needing to expose the entire stageIdToAccumulators ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
