Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/186#discussion_r11099079
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -512,11 +530,12 @@ class DAGScheduler(
        */
       private[scheduler] def processEvent(event: DAGSchedulerEvent): Boolean = 
{
         event match {
    -      case JobSubmitted(jobId, rdd, func, partitions, allowLocal, 
callSite, listener, properties) =>
    --- End diff --
    
    I believe your 100-columns check is incorrect (probably off by 1.)  Kay has 
already done the work of maximizing the readability of DAGScheduler while 
staying within the 100-column limit, so please don't linebreak any of the 
existing lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to