Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/267#discussion_r11099127
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkJLineReader.scala
---
@@ -78,3 +80,11 @@ class SparkJLineReader(_completion: => Completion)
extends InteractiveReader {
def readOneLine(prompt: String) = consoleReader readLine prompt
def readOneKey(prompt: String) = consoleReader readOneKey prompt
}
+
+/** Changes the default history file to not collide with the scala repl's.
*/
+class SparkJLineHistory extends JLineFileHistory {
+ import Properties.userHome
+
+ def defaultFileName = ".spark_history"
+ override protected lazy val historyFile = File(Path(userHome) /
defaultFileName)
--- End diff --
Just wondering - does this handle systems with different path separators
correct?
Does `historyFile` need to be `scala.reflect.io.File`? Or can it be a
`java.io.File`? It seems a little heavyweight to pull in the reflection library
to create a file path, but it makes sense if this is the needed type of
`historyFile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
