Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/186#discussion_r11102141
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -150,7 +162,10 @@ class DAGScheduler(
               }
           }
         }))
    -  }
    +  }))
    +
    +  // set the dagscheduler until after the actor system is ready
    +  taskScheduler.setDAGScheduler(this)
    --- End diff --
    
    DAGScheduler.this should work - no need to add an instance variable
    
    
    On Mon, Mar 31, 2014 at 7:13 AM, Mark Hamstra 
<[email protected]>wrote:
    
    > In core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
    >
    > > @@ -150,7 +162,10 @@ class DAGScheduler(
    > >            }
    > >        }
    > >      }))
    > > -  }
    > > +  }))
    > > +
    > > +  // set the dagscheduler until after the actor system is ready
    > > +  taskScheduler.setDAGScheduler(this)
    >
    > Well, you can't access it as this since this means something else within
    > the eventProcessActor, but I think this should work:
    >
    > private[this] val thisDAGScheduler = 
thisenv.actorSystem.actorOf(Props(new Actor {  // the Supervisor
    >   ...
    >   eventProcessActor = context.actorOf(Props(new Actor {
    >     ...
    >     override def preStart() {
    >       taskScheduler.setDAGScheduler(thisDAGScheduler)
    >     }...
    >
    > --
    > Reply to this email directly or view it on 
GitHub<https://github.com/apache/spark/pull/186/files#r11102108>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to