Github user qqsun8819 commented on the pull request:
https://github.com/apache/spark/pull/214#issuecomment-39079998
@CodingCat Thanks very much for your review.I found out that you main
concern concentrate on two points:1 Merge the two SerializerRunner in two
scheduler backend into one source file. 2. Move the preempt serialization try
catch logic in DAGScheduler into real serialization util method.
Actually the first point came out to me when I write out this patch . But
at last I didn't do it because actually they do different things, and the real
serialization part is pulled out to Utils . So.. But I'll double check it again
For the second point , actually preempt serialization logic stayed in
DAGScheduler for a long time (as far as I first met spark source code), so I
don't know whether there is risk or other problems for scheduler. So I'll check
the code again, and ,always , welcome any other review advice
For time limit, I didn't write test case for this new feature. And I
welcome any test design advice .Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
