Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/248#discussion_r11135942
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/java/Row.scala 
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.api.java
    +
    +import org.apache.spark.sql.catalyst.expressions.Row
    +
    +/**
    + * A result row from a SparkSQL query.
    + */
    +class JavaRow(row: Row) {
    --- End diff --
    
    I've given this some more thought and I'm not sure if we really want to do 
that.  The Scala version of `Row` also is a `Seq[Any]` so brings in a whole 
bunch of Scala functionality.  Also if we wanted to have things like `iterator` 
on the java version of `Row` it would be returning the scala type.  I think the 
same is going to apply to `Generator` which will probably need to operate on 
the java version of functions.
    
    Not super opinionated here though, so let me know if you disagree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to