Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/246#discussion_r11190015
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -505,6 +505,21 @@ class DAGScheduler(
       }
     
       /**
    +   * Cancel all jobs associated with a running or scheduled stage.
    +   */
    +  def cancelStage(stageId: Int) {
    --- End diff --
    
    Also, it would be good to chance the handleJobCancellation() method to 
accept a string exceptionMessage parameter to use when creating the 
SparkException.  For the normal case it can stay as "Job X cancelled", but for 
this case we can say "Job X cancelled because stage Y was cancelled" to make it 
more clear to the user what's going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to