Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/299#discussion_r11235627
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -208,6 +210,26 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
new SparkConf(false).setAll(settings)
}
+ /** Checks for illegal or deprecated config settings. Throws an
exception for the former. */
+ private def validateSettings() {
+ if (settings.contains("spark.local.dir")) {
+ val msg = "In Spark 1.0 and later spark.local.dir will be overridden
by the value set by " +
+ "the cluster manager (via SPARK_LOCAL_DIRS in mesos/standalone and
LOCAL_DIRS in YARN)."
+ logWarning(msg)
+ }
+ val executorOptsKey = "spark.executor.extraJavaOptions"
+ settings.get(executorOptsKey).map { javaOpts =>
+ if (javaOpts.contains("-Dspark")) {
+ val msg = s"$executorOptsKey is not allowed to set Spark options.
Was '$javaOpts'"
+ throw new Exception(msg)
+ }
+ if (javaOpts.contains("-Xmx") || javaOpts.contains("-Xms")) {
+ val msg = s"$executorOptsKey is not allowed to alter memory
settings. Was '$javaOpts'"
--- End diff --
Maybe tell the user what property to set instead.
Also, we could do this same check for SPARK_JAVA_OPTS, since setting the
memory there is overridden by whatever variant of SPARK_MEM is in use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
