Github user kanzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/306#discussion_r11237143
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
    @@ -142,7 +142,7 @@ private[spark] class ExecutorRunner(
           // long-lived processes only. However, in the future, we might 
restart the executor a few
           // times on the same machine.
           val exitCode = process.waitFor()
    -      state = ExecutorState.FAILED
    --- End diff --
    
    BTW, when Worker kills an executor, the ExecutorRunner.workerThread got 
interrupted, while the Executor process itself is destroyed. The above line in 
ExecutorRunner will not get executed, since the thread got interrupted. The 
executor state will not be set here. Instead, it is set in the 
ExecutorRunner.kill() as KILLED. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to