Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/158#discussion_r11264777
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -669,7 +717,7 @@ private[spark] class BlockManager(
// Either we're storing bytes and we asynchronously started
replication, or we're storing
// values and need to serialize and replicate them now:
- if (level.replication > 1) {
+ if (level.replication > 1 && !level.useOffHeap) {
--- End diff --
Instead of doing this, just prevent users from creating a StorageLevel with
offHeap = true and replication = 1. Add a check in the StorageLevel constructor
and throw an exception if they make one. Otherwise nobody will understand why
this code was added here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
