Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/321#discussion_r11319881
  
    --- Diff: dev/run-tests ---
    @@ -49,7 +48,7 @@ dev/scalastyle
     echo 
"========================================================================="
     echo "Running Spark unit tests"
     echo 
"========================================================================="
    -sbt/sbt assembly test
    +echo -e "q\n" | sbt/sbt assembly test |  grep -v -e "info.*Resolving" -e 
"warn.*Merging" -e "info.*Including"
    --- End diff --
    
    If the build file has compilation errors, then sbt blocks on press Q for 
quit etc. in this place it might not be necessary since this can not happen 
here as it would have been already been checked at scalastyle step. Do you 
think we should remove it ? I just thought it is harmless. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to