Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11361448
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,10 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI address. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIAddress = publicHost + ":" + boundPort
--- End diff --
hm - rather than doing this what about having `appUIHostPort` in addition
to `appUIAddress`. Even though address is not an official term, I think people
downstream would expect it to have a scheme (ala
http://en.wikipedia.org/wiki/Uniform_resource_locator).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
