Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/296#discussion_r11364039
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/rdd/RowRDDMatrix.scala ---
@@ -0,0 +1,327 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.mllib.linalg.rdd
+
+import java.util
+
+import scala.util.control.Breaks._
+
+import breeze.linalg.{DenseMatrix => BDM, DenseVector => BDV, svd =>
brzSvd}
+import breeze.numerics.{sqrt => brzSqrt}
+import com.github.fommil.netlib.BLAS.{getInstance => blas}
+
+import org.apache.spark.mllib.linalg._
+import org.apache.spark.rdd.RDD
+import org.apache.spark.Logging
+
+/**
+ * Represents a row-oriented RDDMatrix with no meaningful row indices.
+ *
+ * @param rows rows stored as an RDD[Vector]
+ * @param m number of rows
+ * @param n number of columns
+ */
+class RowRDDMatrix(
+ val rows: RDD[Vector],
+ m: Long = -1L,
+ n: Long = -1) extends RDDMatrix with Logging {
--- End diff --
Actually I see, they're just to let the user specify these. In that case
they should be documented as such and maybe just called "rows" and "columns".
Also, this constructor is not Java-friendly; you should make these arguments
not have defaults and then add alternative constructors in the body of the
class that pass -1 for them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
