Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/246#discussion_r11426048
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -71,15 +71,28 @@ private[ui] class StageTable(stages: Seq[StageInfo],
parent: JobProgressUI) {
</div>
}
- /** Render an HTML row that represents a stage */
- private def stageRow(s: StageInfo): Seq[Node] = {
- val poolName = listener.stageIdToPool.get(s.stageId)
+ private def makeDescription(s: StageInfo): Seq[Node] = {
val nameLink =
<a
href={"%s/stages/stage?id=%s".format(UIUtils.prependBaseUri(basePath),
s.stageId)}>
{s.name}
</a>
+ val killButton = if (killEnabled) {
+ <form
action={"%s/stages/stage/".format(UIUtils.prependBaseUri(basePath))}>
--- End diff --
instead of using a form here with POST parameters and a submit button,
could we just have a link? The button looks really out of place in our UI and a
bit clunky. For now what about having a small link right next to the stage name
that says "[kill]"? Then we can style it more later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
