Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/369#issuecomment-40010754
Through this pull request, I just realized how inefficient the sorting code
was (one that takes Ordered). I'm glad you are using Ordering instead. We
should change the sortByKey implementation ...
For the test code, do you mind removing the extra spaces you used to align
=s?
And can we take an implicit Ordering like the way Scala lib does? This way,
the user can also change the ordering.
On Wed, Apr 9, 2014 at 7:40 AM, Andrew Ash <[email protected]> wrote:
> This never got merged from the apache/incubator-spark repo (which is now
> deleted) but there had been several rounds of code review on this PR
there.
>
> I think this is ready for merging.
> ------------------------------
> You can merge this Pull Request by running
>
> git pull https://github.com/ash211/spark sortby
>
> Or view, comment on, or merge it at:
>
> https://github.com/apache/spark/pull/369
> Commit Summary
>
> - Add .sortBy(f) method on RDD
> - Merge remote-tracking branch 'origin/master' into sortby
> - Support ascending and numPartitions params in sortBy()
> - Correct silly typo
> - Actually use ascending and numPartitions parameters
>
> File Changes
>
> - *M*
core/src/main/scala/org/apache/spark/rdd/RDD.scala<https://github.com/apache/spark/pull/369/files#diff-0>(11)
> - *M*
core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala<https://github.com/apache/spark/pull/369/files#diff-1>(12)
>
> Patch Links:
>
> - https://github.com/apache/spark/pull/369.patch
> - https://github.com/apache/spark/pull/369.diff
>
> --
> Reply to this email directly or view it on
GitHub<https://github.com/apache/spark/pull/369>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
