Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/186#discussion_r11491580
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1128,13 +986,160 @@ class DAGScheduler(
}
def stop() {
- if (eventProcessActor != null) {
- eventProcessActor ! StopDAGScheduler
+ logInfo("Stopping DAGScheduler")
+ if (dagSchedulerActorSupervisor != null) {
+ dagSchedulerActorSupervisor ! PoisonPill.getInstance
--- End diff --
That could be right -- sorry, haven't had time to unwind it further. If
I'm understanding correctly, that would make the double postStop a testing-only
occurrence; but I don't think that it will hurt anything to always remove jobs
from activeJobs after they are handled in postStop, so that if/when postStop
does run more than once there is nothing more to do in `for (job <-
dagScheduler.activeJobs)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
