Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/290#discussion_r11517823
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -213,6 +192,18 @@ class HistoryServer(
fileSystem.close()
}
+ /** Attach a reconstructed UI to this server. Only valid after bind(). */
+ private def attachUI(ui: SparkUI) {
--- End diff --
minor: `attachUI` is pretty generic - what bout calling this
`attachApplicationUI` or even just `attachSparkUI`? Separately I'm wondering if
`SparkUI` should be renamed to be more specific. E.g. `SparkAppUI`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
