Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/266#issuecomment-40275465
Hold up a sec -- the array copy is not new. It was merely hidden in the
call to `trim()` before, or to `ByteBuffer.allocate()`. Yes, it's better to
avoid it if possible. The problem is not just about getting at a `byte[]` but
one of the right size. So at least I think this is no worse than it was before,
no emergency just yet. Might be best to really fix this up per Mridul's
suggestion to use `Seq[ByteBuffer]`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
