GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/404

    SPARK-1488. Resolve scalac feature warnings during build

    For your consideration: scalac currently notes a number of feature warnings 
during compilation:
    
    ```
    [warn] there were 65 feature warning(s); re-run with -feature for details
    ```
    
    Warnings are like:
    
    ```
    [warn] 
/Users/srowen/Documents/spark/core/src/main/scala/org/apache/spark/SparkContext.scala:1261:
 implicit conversion method rddToPairRDDFunctions should be enabled
    [warn] by making the implicit value scala.language.implicitConversions 
visible.
    [warn] This can be achieved by adding the import clause 'import 
scala.language.implicitConversions'
    [warn] or by setting the compiler option -language:implicitConversions.
    [warn] See the Scala docs for value scala.language.implicitConversions for 
a discussion
    [warn] why the feature should be explicitly enabled.
    [warn]   implicit def rddToPairRDDFunctions[K: ClassTag, V: ClassTag](rdd: 
RDD[(K, V)]) =
    [warn]                ^
    ```
    
    scalac is suggesting that it's just best practice to explicitly enable 
certain language features by importing them where used.
    
    This PR simply adds the imports it suggests (and squashes one other Java 
warning along the way). This leaves just deprecation warnings in the build.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-1488

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #404
    
----
commit 39bc83115d5a55527e4f893fd480039896b6a63f
Author: Sean Owen <[email protected]>
Date:   2014-04-08T11:24:28Z

    Enable -feature in scalac to emit language feature warnings

commit 859898002573f24c53d458db3e61b91b3c9da841
Author: Sean Owen <[email protected]>
Date:   2014-04-08T12:09:45Z

    Quiet scalac warnings about language features by explicitly importing 
language features.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to