Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/395#issuecomment-40436753
Thanks for adding this! It would be great if you could create a JIRA for
tracking this new feature. Also, right now HashJoin is only used for Inner
joins, though it would be good to also extend that at some point (though maybe
not in this PR).
One design question is which of the following is better:
- multiple operators that handle different kinds of joins, letting the
planner pick the correct one
- putting the switching logic inside of the operator as is done here
I need to look at this code closer, but will not have time to do that until
after we start cutting release candidates for 1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
