Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40747230
@berngp Thanks for doing this. I literally ran into this NPE yesterday in
my own YARN cluster. It turns out I forgot to point YARN_CONF_DIR to the proper
place, but running into a NPE did not leave any clue as to what the problem is
(until I dug into the code, which is bad user experience). This PR is a much
needed fix.
I left a couple of comments. As @tgraves mentioned, the style of this PR is
inconsistent with the Spark style guide. Further, it would be good if we could
remove several levels of indirection to make the code clearer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
