GitHub user kenahoo opened a pull request:
https://github.com/apache/spark/pull/449
Updates to shell globbing in run-example and spark-class
I was running into some shell problems & warnings that I couldn't figure
out. It turned out I had a few jars left over from previous builds.
There were a few inconsistencies in how shell globbing was done, and some
places where the code assumed only one file could match a glob, with unsightly
consequences if more than one file matched. I wrote a couple functions that
handle globbing in a more consistent way, and use them in the workhorse
scripts. With these changes it should be more obvious to someone like me what
the problem is.
I'm not a Bash expert, BTW. Much of Bash's syntax looks screwy to me, if
there's some better way to do what I did, by all means modify.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kenahoo/spark shell-invokers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #449
----
commit 9f4a98755ae5c5b0cf9357b2a2588e1018921e64
Author: Ken Williams <[email protected]>
Date: 2014-04-17T22:13:56Z
More informative errors when multiple/no jars can be found
commit dea17f661f4cc6c220341ca7aeceb270aa9e7c88
Author: Ken Williams <[email protected]>
Date: 2014-04-17T22:14:21Z
More accurate error message when we can't find a good Java
commit c92c43a5d493910bc25553c6a3852c419e4a748c
Author: Ken Williams <[email protected]>
Date: 2014-04-18T17:36:01Z
Extract some globbing functions into a new sh-funcs.sh file
commit 89fb523751aa1bab65adc442543ca96cbeb82ddb
Author: Ken Williams <[email protected]>
Date: 2014-04-18T21:11:07Z
Put pattern in a $pat variable
commit ec7463926c324e0055ef416b6d3e0f5cd34058bb
Author: Ken Williams <[email protected]>
Date: 2014-04-18T22:22:31Z
Add some comments and be a little more careful about quoting
commit 14d06b91466d2a9473340cad36214fe6a0b207a1
Author: Ken Williams <[email protected]>
Date: 2014-04-18T22:26:00Z
One more comment
commit 031041d1acb5e3d8eceb6359ae4c9b2d9b6dac56
Author: Ken Williams <[email protected]>
Date: 2014-04-18T22:29:18Z
Merge branch 'master' into shell-invokers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
