Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/421#discussion_r11794343
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
    @@ -27,34 +27,36 @@ import org.apache.spark.ui.UIUtils
     import org.apache.spark.util.Utils
     
     /** Page showing list of all ongoing and recently finished stages */
    -private[ui] class StageTable(
    +private[ui] class StageTableBase(
         stages: Seq[StageInfo],
         parent: JobProgressTab,
         killEnabled: Boolean = false) {
     
       private val basePath = parent.basePath
       private val listener = parent.listener
    -  private lazy val isFairScheduler = parent.isFairScheduler
    +  protected lazy val isFairScheduler = parent.isFairScheduler
    +
    +  protected lazy val columns = {
    --- End diff --
    
    It would probably be best to just make this a def, so 
FailedStageTable#columns can just append to the list. isFairScheduler should 
probably also be a def, as checking the volatile variable is almost certainly 
more expensive than a method call to check a boolean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to