Github user tmyklebu commented on a diff in the pull request:
https://github.com/apache/spark/pull/407#discussion_r11795344
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala ---
@@ -128,6 +128,34 @@ class ALSSuite extends FunSuite with LocalSparkContext
{
assert(u11 != u2)
}
+ test("custom partitioner") {
+ testALS(50, 50, 2, 15, 0.7, 0.3, false, false, false, 3, null)
+ testALS(50, 50, 2, 15, 0.7, 0.3, false, false, false, 3, new
Partitioner {
+ def numPartitions(): Int = 3
+ def getPartition(x: Any): Int = x match {
+ case null => 0
--- End diff --
OK; I'll remove the null case. % 2 was intentional; this test may as well
cover the last-partition-is-empty case as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
