HeartSaVioR commented on a change in pull request #26127: [SPARK-29348][SQL]
Add observable Metrics for Streaming queries
URL: https://github.com/apache/spark/pull/26127#discussion_r361887010
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -106,6 +106,9 @@ class QueryExecution(
lazy val toRdd: RDD[InternalRow] = new SQLExecutionRDD(
executedPlan.execute(), sparkSession.sessionState.conf)
+ /** Get the metrics observed during the execution of the query plan. */
+ def observedMetrics: Map[String, Row] =
CollectMetricsExec.collect(executedPlan)
Review comment:
Technically, QueryExecution should be public class, as two methods in
QueryExecutionListener are marked as `@DeveloperApi` and the signature of
methods contain QueryExecution. If we worry about restriction for modifying
QueryException due to being public class, we may need to have other class only
for reporting to QueryExecutionListener.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
