HyukjinKwon commented on a change in pull request #26127: [SPARK-29348][SQL]
Add observable Metrics for Streaming queries
URL: https://github.com/apache/spark/pull/26127#discussion_r361890120
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -106,6 +106,9 @@ class QueryExecution(
lazy val toRdd: RDD[InternalRow] = new SQLExecutionRDD(
executedPlan.execute(), sparkSession.sessionState.conf)
+ /** Get the metrics observed during the execution of the query plan. */
+ def observedMetrics: Map[String, Row] =
CollectMetricsExec.collect(executedPlan)
Review comment:
Yeah, `StreamingQueryProgress.observedMetrics` with `StreamingQueryListener`
seems fine. The problem here looks only `QueryExecution.observedMetrics` with
`QueryExecutionListener`, which looks having a contradiction about its
stability. It seems it has to be fixed by either avoid adding it to
`QueryExecution` or explicitly marking `Dataset.observe` as an unstable API (or
developer API).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
