viirya commented on a change in pull request #27038: [SPARK-30379][Core] Avoid
OOM when using collection accumulator
URL: https://github.com/apache/spark/pull/27038#discussion_r361905102
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -625,10 +626,19 @@ private class SchedulerPool(name: String) extends
LiveEntity {
}
-private object LiveEntityHelpers {
+private[spark] object LiveEntityHelpers {
private val stringInterner = Interners.newWeakInterner[String]()
+ private def accuValuetoString(value: Any): String = value match {
+ case list: java.util.List[_] =>
+ if (list.size() > 5) {
Review comment:
This is a number for avoiding OOM issue. For UI, good or not might be case
by case. Although it sounds okay to add a config, I feel it is not a big deal
to adjust this number in UI and api. I suggest to leave it as 5 and if we need
to configure it, we can add a config later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
