HyukjinKwon commented on a change in pull request #27031: [SPARK-30373][SQL]
Avoid unnecessary sort for ParquetUtils.splitFiles
URL: https://github.com/apache/spark/pull/27031#discussion_r361934666
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetUtils.scala
##########
@@ -112,15 +114,26 @@ object ParquetUtils {
metadata: Seq[FileStatus],
commonMetadata: Seq[FileStatus])
- private def splitFiles(allFiles: Seq[FileStatus]): FileTypes = {
- val leaves = allFiles.toArray.sortBy(_.getPath.toString)
Review comment:
That's true but users always find awesome ways to use or abuse :-). True,
this case `mergeSchema` have better to be set `true` but many people want to
avoid in production because `mergeSchema` is super expensive as it needs to
touch every file.
In non performance sensitive codes, we better keep the codes simple and more
readable anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
