hvanhovell commented on a change in pull request #26997: [SPARK-30343][SQL]
Skip unnecessary checks in RewriteDistinctAggregates
URL: https://github.com/apache/spark/pull/26997#discussion_r361969822
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -101,8 +101,17 @@ import org.apache.spark.sql.types.IntegerType
*/
object RewriteDistinctAggregates extends Rule[LogicalPlan] {
+ private def mayNeedtoRewrite(exprs: Seq[Expression]): Boolean = {
+ val distinctAggs = exprs.flatMap { _.collect {
+ case ae: AggregateExpression if ae.isDistinct => ae
+ }}
+ // We need at least two distinct aggregates for this rule because
aggregation
Review comment:
Let's add a comment that this can produce false positives, i.e.
`sum(distinct a)` & `count(distinct a)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
