Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4577#discussion_r24630445
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala 
---
    @@ -202,7 +202,7 @@ private[spark] class PythonRDD(
           this.interrupt()
         }
     
    -    override def run(): Unit = Utils.logUncaughtExceptions {
    +    override def run(): Unit = Utils.tryLog {
    --- End diff --
    
    Instead of doing a big tryLog (which is sort of dangerous because of the 
potential of users adding a return statement that would break this code), can 
we add an explicit try around the two `worker.shutdownOutput()` calls?
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to