srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362009205
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable,
PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable
table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be
set a minimum share
Review comment:
These are a bit too long for tooltips. They are meant to elaborate, very
briefly, the immediate meaning of the column. More like "Pool's minimum share
of CPU cores"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
