cloud-fan commented on a change in pull request #26813: [SPARK-30188][SQL][WIP]
Enable adaptive query execution by default
URL: https://github.com/apache/spark/pull/26813#discussion_r362050733
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2034,7 +2041,7 @@ class DataFrameSuite extends QueryTest with
SharedSparkSession {
.select(when($"cond", array(lit("a"), lit("b"))).otherwise($"a") as
"res")
.select($"res".getItem(0))
def mapWhenDF: DataFrame = sourceDF
- .select(when($"cond", map(lit(0), lit("a"))).otherwise($"m") as "res")
+ .select(when($"cond", functions.map(lit(0), lit("a"))).otherwise($"m")
as "res")
Review comment:
to avoid naming conflicts, how about rename `AdaptiveSparkPlanHelper.map` to
`mapPlans`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
