yaooqinn commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r362136843
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -720,6 +722,14 @@ class Analyzer(
}
}
+ case class ResolveNamespace(catalogManager: CatalogManager)
+ extends Rule[LogicalPlan] with LookupCatalog {
+ def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
+ ResolvedNamespace(catalog.asNamespaceCatalog, ns)
+ }
Review comment:
Yes, see
https://github.com/apache/spark/pull/26847#issuecomment-567516386
> We can have an extra rule to catch commands with v1 relation, and convert
them to v1 commands. This can help us get rid of the duplicated code between
ResolveCatalogs and ResolveSessionCatalog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
