srowen commented on a change in pull request #27059: [SPARK-30398][ML]
PCA/RegressionMetrics/RowMatrix avoid unnecessary computation
URL: https://github.com/apache/spark/pull/27059#discussion_r362233532
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
##########
@@ -21,6 +21,7 @@ import scala.annotation.varargs
import org.apache.spark.annotation.Since
import org.apache.spark.api.java.{JavaDoubleRDD, JavaRDD}
+import org.apache.spark.ml.stat.SummaryBuilderImpl._
Review comment:
Design wise, can we minimize the places where mllib calls ml? and is it
possible to expose this without reaching into the "Impl" class? it looks a
little funny
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
