cloud-fan commented on a change in pull request #27073: 
[SPARK-29768][SQL][FOLLOW-UP]Improve handling non-deterministic filter of 
ScanOperation
URL: https://github.com/apache/spark/pull/27073#discussion_r362406545
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
 ##########
 @@ -148,6 +148,7 @@ object FileSourceStrategy extends Strategy with Logging {
       val filterSet = ExpressionSet(filters)
 
       val normalizedFilters = DataSourceStrategy.normalizeExprs(filters, 
l.output)
+        .filter(_.deterministic)
 
 Review comment:
   nit: `DataSourceStrategy.normalizeExprs(filters.filter(_.deterministic), 
l.output)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to