AngersZhuuuu commented on a change in pull request #26437: [SPARK-29800][SQL]
Plan non-correlated Exists 's subquery in PlanSubqueries
URL: https://github.com/apache/spark/pull/26437#discussion_r362449495
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -52,6 +52,16 @@ object ReplaceExpressions extends Rule[LogicalPlan] {
}
}
+object ReplaceNonCorrelatedExists extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan
transformAllExpressions {
+ case exists: Exists
+ if !SubqueryExpression.hasInOrCorrelatedExistsSubquery(exists) =>
+ IsNotNull(
+ ScalarSubquery(
+ plan = Limit(Literal(1, IntegerType), exists.plan),
Review comment:
> nit: `Limit(Literal(1), Project(Literal(1), exists.plan))`
Project need `NamedExpression`, need to construct one like below ?
```
Project(Seq(Alias(Literal(1), s"col_${NamedExpression.newExprId}")()),
exists.plan)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
