imatiach-msft commented on a change in pull request #27070:
[SPARK-9612][ML][FOLLOWUP] fix GBT support weights if subsamplingRate<1
URL: https://github.com/apache/spark/pull/27070#discussion_r362577841
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala
##########
@@ -100,43 +100,24 @@ private[spark] object RandomForest extends Logging with
Serializable {
run(instances, strategy, numTrees, featureSubsetStrategy, seed, None)
}
- def buildMetadata(
- input: RDD[Instance],
- strategy: OldStrategy,
- numTrees: Int,
- featureSubsetStrategy: String): DecisionTreeMetadata = {
- val retaggedInput = input.retag(classOf[Instance])
- DecisionTreeMetadata.buildMetadata(retaggedInput, strategy, numTrees,
featureSubsetStrategy)
- }
-
/**
* Train a random forest.
Review comment:
Update doc, eg:
```
Train a random forest with metadata.
```
also add description for metadata param
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
