zhengruifeng commented on a change in pull request #27059: [SPARK-30398][ML]
PCA/RegressionMetrics/RowMatrix avoid unnecessary computation
URL: https://github.com/apache/spark/pull/27059#discussion_r362700336
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
##########
@@ -21,6 +21,7 @@ import scala.annotation.varargs
import org.apache.spark.annotation.Since
import org.apache.spark.api.java.{JavaDoubleRDD, JavaRDD}
+import org.apache.spark.ml.stat._
Review comment:
I guess I can move impl to /ml, will have a try
> Most of the change here is breaking out the inner class right?
Yes, if we move impl to /ml. I guess I may not need to breaking out it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
