HyukjinKwon commented on a change in pull request #26644: [SPARK-30004][SQL]
Allow merge UserDefinedType into a native DataType
URL: https://github.com/apache/spark/pull/26644#discussion_r362721679
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/TestUDT.scala
##########
@@ -58,4 +63,22 @@ object TestUDT {
override def equals(other: Any): Boolean =
other.isInstanceOf[MyDenseVectorUDT]
}
+
+ private[sql] class MyXMLGregorianCalendarUDT extends
UserDefinedType[XMLGregorianCalendar] {
+ override def sqlType: DataType = TimestampType
+
+ override def serialize(obj: XMLGregorianCalendar): Any =
+ obj.toGregorianCalendar.getTimeInMillis * 1000
+
+ override def deserialize(datum: Any): XMLGregorianCalendar = {
+ val calendar = new GregorianCalendar
+ calendar.setTimeInMillis(datum.asInstanceOf[Long])
+ DatatypeFactory.newInstance.newXMLGregorianCalendar(calendar)
+ }
+
+ override def userClass: Class[XMLGregorianCalendar] =
classOf[XMLGregorianCalendar]
+
+ // By setting this to a timestamp, we lose the information about the udt
+ override private[sql] def jsonValue: JValue = "timestamp"
Review comment:
This is a bit odd .. wouldn't it be a timestamp whenever it does a roundtrip
in ser/de?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
