cloud-fan commented on a change in pull request #27073:
[SPARK-29768][SQL][FOLLOW-UP]Improve handling non-deterministic filter of
ScanOperation
URL: https://github.com/apache/spark/pull/27073#discussion_r362725841
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -35,7 +33,9 @@ trait OperationHelper {
})
protected def substitute(aliases: AttributeMap[Expression])(expr:
Expression): Expression = {
- expr.transform {
+ // use transformUp instead of transformDown to avoid dead loop
+ // in case of there's Alias which recursively alias itself.
Review comment:
there's Alias whose exprId is the same as its child attribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
