cloud-fan commented on a change in pull request #26806: [SPARK-30183][SQL]
Disallow to specify reserved properties in CREATE …
URL: https://github.com/apache/spark/pull/26806#discussion_r362826941
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2525,17 +2526,21 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
var properties = ctx.tablePropertyList.asScala.headOption
.map(visitPropertyKeyValues)
.getOrElse(Map.empty)
- Option(ctx.comment).map(string).map {
- properties += SupportsNamespaces.PROP_COMMENT -> _
+
+ if
(properties.keySet.intersect(RESERVED_PROPERTIES.asScala.toSet).nonEmpty) {
Review comment:
shall we do the check inside `CreateNamespace` command? in case we have
other APIs that can create `CreateNamespace` command in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
