vanzin commented on a change in pull request #27010: [SPARK-30313][CORE] Ensure
EndpointRef is available MasterWebUI/WorkerPage
URL: https://github.com/apache/spark/pull/27010#discussion_r362657084
##########
File path: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
##########
@@ -68,11 +66,27 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv,
numUsableCores: Int) exte
if (stopped) {
throw new IllegalStateException("RpcEnv has been stopped")
}
- if (endpoints.putIfAbsent(name, getMessageLoop(name, endpoint)) != null)
{
+ if (endpoints.containsKey(name)) {
throw new IllegalArgumentException(s"There is already an RpcEndpoint
called $name")
}
+ val msgLoop = findMessageLoop(name, endpoint)
+ endpoints.put(name, msgLoop)
+ try {
+ endpointRefs.put(endpoint, endpointRef)
Review comment:
Hmm, I can't find a way to see the complete patch at a specific commit in
the UI, so I'll say "maybe".
The goal is:
- not modify "endpoints" when checking if the endpoint exists
- update "endpointRefs" before registering the endpoint's message loop
(calling `register` in the case of the shared loop, or creating the dedicated
message loop)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
