srowen commented on a change in pull request #27094: [SPARK-30419][ML][PySpark]
Make IsotonicRegression extend Regressor
URL: https://github.com/apache/spark/pull/27094#discussion_r363051568
##########
File path: project/MimaExcludes.scala
##########
@@ -465,7 +465,15 @@ object MimaExcludes {
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.appendS3AndSparkHadoopConfigurations"),
// [SPARK-29348] Add observable metrics.
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.streaming.StreamingQueryProgress.this")
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.streaming.StreamingQueryProgress.this"),
+
+ // [SPARK-30419][ML] Make IsotonicRegression extend Regressor
+
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.regression.IsotonicRegression.fit"),
+
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.regression.IsotonicRegression.setFeaturesCol"),
Review comment:
Hm, weird, because Learner is the type IsotonicRegression here. So it
shouldn't be a real change. I wonder if it's just a MiMa problem.
So as far as you know this isn't changing any APIs right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
