AngersZhuuuu commented on a change in pull request #26141:
[SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync
mode
URL: https://github.com/apache/spark/pull/26141#discussion_r363169817
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -242,6 +242,10 @@ private[hive] class SparkExecuteStatementOperation(
val executionHiveClassLoader = sqlContext.sharedState.jarClassLoader
Thread.currentThread().setContextClassLoader(executionHiveClassLoader)
+ if (!runInBackground) {
+
parentSession.getSessionState.getConf.setClassLoader(executionHiveClassLoader)
Review comment:
> do we need to set it back?
No need, in our env, just changed like this works fine. if we set it back
after `execute()`,
may have problem when re-compute.
This class loader is not used in thrift server side code.
in `hive` about module, use `executionHiveClassLoader ` is also reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
